Skip to content

Remove get service method and get service#9275

Merged
eelcovdw merged 15 commits intodevfrom
remove_get_service_method
Sep 9, 2024
Merged

Remove get service method and get service#9275
eelcovdw merged 15 commits intodevfrom
remove_get_service_method

Conversation

@teo-milea
Copy link
Member

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@eelcovdw
Copy link
Contributor

eelcovdw commented Sep 9, 2024

Nice!

Does this also add autocomplete to context.server.services? On dev we don't have it, because context.server is an AbstractServer (and not a Server). added comment on the ticket

@teo-milea
Copy link
Member Author

@eelcovdw I don't think I've added that before, can you help with some details and I will add it as well

Copy link
Contributor

@eelcovdw eelcovdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@eelcovdw eelcovdw enabled auto-merge September 9, 2024 17:03
@eelcovdw eelcovdw merged commit 3e189db into dev Sep 9, 2024
@eelcovdw eelcovdw deleted the remove_get_service_method branch September 9, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants