Sync testing (L0) with k8s added to CI#9281
Merged
koenvanderveen merged 6 commits intodevfrom Sep 11, 2024
Merged
Conversation
Co-authored-by: Sameer Wagh <snwagh@users.noreply.github.com>
Co-authored-by: Brendan Schell <brendanschell1@gmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: Brendan Schell <brendanschell1@gmail.com>
| @@ -1,5 +1,35 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
| @@ -3,9 +3,37 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
in this notebook I would love some headings and structure similar to the current refactored scenario notebooks, its quite hard to read like this
Reply via ReviewNB
koenvanderveen
approved these changes
Sep 11, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CI for testing L0 notebooks over k8s. Tests are only added for the sync flows, rest of the testing is in the parent folder.
Closes https://github.com/OpenMined/Heartbeat/issues/1830