Skip to content

Sync testing (L0) with k8s added to CI#9281

Merged
koenvanderveen merged 6 commits intodevfrom
bschell/k8s-l0-ci
Sep 11, 2024
Merged

Sync testing (L0) with k8s added to CI#9281
koenvanderveen merged 6 commits intodevfrom
bschell/k8s-l0-ci

Conversation

@snwagh
Copy link
Contributor

@snwagh snwagh commented Sep 10, 2024

Added CI for testing L0 notebooks over k8s. Tests are only added for the sync flows, rest of the testing is in the parent folder.

Closes https://github.com/OpenMined/Heartbeat/issues/1830

BrendanSchell and others added 2 commits September 10, 2024 14:29
Co-authored-by: Sameer Wagh <snwagh@users.noreply.github.com>
Co-authored-by: Brendan Schell <brendanschell1@gmail.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@snwagh snwagh changed the title [WIP] - Sync (L0) with k8s added to CI Sync testing (L0) with k8s added to CI Sep 11, 2024
@@ -1,5 +1,35 @@
{
Copy link
Collaborator

@koenvanderveen koenvanderveen Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we doing this?


Reply via ReviewNB

@@ -3,9 +3,37 @@
{
Copy link
Collaborator

@koenvanderveen koenvanderveen Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this notebook I would love some headings and structure similar to the current refactored scenario notebooks, its quite hard to read like this


Reply via ReviewNB

@koenvanderveen koenvanderveen merged commit 888aabb into dev Sep 11, 2024
@koenvanderveen koenvanderveen deleted the bschell/k8s-l0-ci branch September 11, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants