Merged
Conversation
- add environment and settings variables for postgres - new error handling for postgresql store
- add postgres service to devspace - pass postgres creds to backend Co-authored-by: khoaguin <dkn.work@protonmail.com>
…ingStore` [tox] trying to delete a datasite cluster before launching
[chores] improve some debug printings
…d postgre backing store - postgre's cursor is not cached and renewed whenever a command is executed Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
- scanning for for postgres container security instead of mongo
- remove mongo from gcp helm charts
- remove ununsed scripts
add a query executor class
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
move db manager and db config to base.py define postgres db manager fix json_quote based on postgres or sqlite fix lint
rename sqilte_db.py to sqlite.py
Co-authored-by: khoaguin <dkn.work@protonmail.com>
shubham3121
added
the
Type: Improvement 📈
eelcovdw
reviewed
Sep 12, 2024
| db_config.reset = True | ||
|
|
||
| self.db_config = db_config | ||
| self.db: PostgresDBManager | SQLiteDBManager | None = None |
Contributor
There was a problem hiding this comment.
should be self.db: DBManager (and not nullable)
perhaps:
self.db = self.init_db(db_config)
eelcovdw
reviewed
Sep 12, 2024
| server_uid=self.id, | ||
| root_verify_key=self.verify_key, | ||
| ) | ||
| if isinstance(db_config, SQLiteDBConfig): |
Contributor
There was a problem hiding this comment.
nitpick, perhaps we can add factory method on DBManager that handles this
Member
Author
There was a problem hiding this comment.
I differ a bit on this, since there are only two types of config currently, being explicit make sense to me.
Contributor
|
great! 💯 |
update init_stores to return db manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist