Skip to content

Fix/rename worker pool var name#9319

Merged
IonesioJunior merged 6 commits intodevfrom
fix/rename_worker_pool_var_name
Sep 25, 2024
Merged

Fix/rename worker pool var name#9319
IonesioJunior merged 6 commits intodevfrom
fix/rename_worker_pool_var_name

Conversation

@IonesioJunior
Copy link
Member

@IonesioJunior IonesioJunior commented Sep 25, 2024

Description

Aims to fix parameter name incosistency between syft_functions and twin_apis worker_pool/worker_pool_name issue

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

- Create a new TwinAPIEndpointView Version
- Create a new TwinAPIEndpoint Version
- Create a new CreateTwinAPIEndpoint Version
- Change api_endpoint decorator signature
- Change create_api_endpoint decorator signature
- Change make_schema signature
- Change make_submit_query signature
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@IonesioJunior IonesioJunior changed the title [WIP] Fix/rename worker pool var name Fix/rename worker pool var name Sep 25, 2024
@IonesioJunior IonesioJunior marked this pull request as ready for review September 25, 2024 14:45
@IonesioJunior IonesioJunior merged commit fd58782 into dev Sep 25, 2024
@IonesioJunior IonesioJunior deleted the fix/rename_worker_pool_var_name branch September 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants