Skip to content

Update submit query to use user_client instead of admin_client#9329

Merged
snwagh merged 2 commits intodevfrom
bschell/update-bigquery-notebooks-to-use-ds-users
Oct 1, 2024
Merged

Update submit query to use user_client instead of admin_client#9329
snwagh merged 2 commits intodevfrom
bschell/update-bigquery-notebooks-to-use-ds-users

Conversation

@BrendanSchell
Copy link
Contributor

Description

Small update to make submit query endpoint used in notebooks use user_client instead of admin_client where possible. Otherwise, it seems like the bigquery notebooks are using DS clients to submit using this endpoint and not admin clients.

Closes https://github.com/OpenMined/Heartbeat/issues/1873.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@snwagh snwagh enabled auto-merge October 1, 2024 14:09
@snwagh snwagh self-requested a review October 1, 2024 14:09
Copy link
Contributor

@snwagh snwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snwagh snwagh merged commit 56d5464 into dev Oct 1, 2024
@snwagh snwagh deleted the bschell/update-bigquery-notebooks-to-use-ds-users branch October 1, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants