Skip to content

Worker API#101

Merged
cereallarceny merged 5 commits intomasterfrom
vvm/worker-api
Mar 10, 2020
Merged

Worker API#101
cereallarceny merged 5 commits intomasterfrom
vvm/worker-api

Conversation

@vvmnnnkv
Copy link
Member

Initial implementation of #87
Scaffolds for following entities added:

  • GridAPIClient
  • SyftWorker
  • Job
  • SyftModel

"with-grid" example is updated with data loading and simple training plan loop (that doesn't execute plan yet).

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #101 into master will decrease coverage by 8.10%.
The diff coverage is 39.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   85.97%   77.86%   -8.11%     
==========================================
  Files          18       21       +3     
  Lines         556      610      +54     
  Branches       80       81       +1     
==========================================
- Hits          478      475       -3     
- Misses         67      118      +51     
- Partials       11       17       +6     
Impacted Files Coverage Δ
src/data-channel-message-queue.js 100.00% <ø> (ø)
src/data-channel-message.js 100.00% <ø> (ø)
src/job.js 0.00% <0.00%> (ø)
src/syft_model.js 0.00% <0.00%> (ø)
src/webrtc.js 90.66% <ø> (ø)
src/grid-api-client.js 10.52% <10.52%> (ø)
src/_errors.js 63.63% <50.00%> (-3.04%) ⬇️
src/syft.js 14.00% <55.55%> (-33.83%) ⬇️
src/types/message.js 83.33% <66.66%> (-0.99%) ⬇️
src/_helpers.js 95.23% <75.00%> (-4.77%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5898738...3481a71. Read the comment docs.

@vvmnnnkv vvmnnnkv requested a review from cereallarceny March 2, 2020 11:37
Copy link
Member

@cereallarceny cereallarceny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@vvmnnnkv vvmnnnkv marked this pull request as ready for review March 9, 2020 18:33
@vvmnnnkv vvmnnnkv requested a review from cereallarceny March 9, 2020 18:33
Copy link
Member

@cereallarceny cereallarceny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @vvmnnnkv

@cereallarceny cereallarceny merged commit 1f0b999 into master Mar 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the vvm/worker-api branch March 10, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants