Merged
Conversation
cereallarceny
suggested changes
Feb 26, 2020
Member
cereallarceny
left a comment
There was a problem hiding this comment.
@IamRavikantSingh A few initial questions I have. Also, this doesn't actually run ESLint as part of the watch or build commands in package.json. Please ensure that ESLint is actually running via the CLI commands and not via your code editor.
e7af1ed to
1e132cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
===========================================
- Coverage 85.97% 72.48% -13.49%
===========================================
Files 18 18
Lines 556 556
Branches 80 80
===========================================
- Hits 478 403 -75
- Misses 67 123 +56
- Partials 11 30 +19
Continue to review full report at Codecov.
|
ee82521 to
1e132cd
Compare
cereallarceny
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#62
For review by @cereallarceny