Skip to content

Eslint error fix#104

Merged
vvmnnnkv merged 3 commits intoOpenMined:masterfrom
rav7kantsingh:eslint-error-fix
Mar 1, 2020
Merged

Eslint error fix#104
vvmnnnkv merged 3 commits intoOpenMined:masterfrom
rav7kantsingh:eslint-error-fix

Conversation

@rav7kantsingh
Copy link
Member

@rav7kantsingh rav7kantsingh commented Feb 27, 2020

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #104 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          18       18           
  Lines         556      556           
  Branches       80       80           
=======================================
  Hits          478      478           
  Misses         67       67           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6304b72...25e42fa. Read the comment docs.

@cereallarceny
Copy link
Member

For the record, we won't be merging this PR until we have 100% passing tests. We don't need to have 100% test coverage, but we need all failing tests and linting errors to be resolved.

@rav7kantsingh
Copy link
Member Author

For the record, we won't be merging this PR until we have 100% passing tests. We don't need to have 100% test coverage, but we need all failing tests and linting errors to be resolved.

This pr only contains eslint error fix and for jest test fails I am working on another Pr #105

@vvmnnnkv
Copy link
Member

vvmnnnkv commented Mar 1, 2020

Thanks!

@vvmnnnkv vvmnnnkv merged commit 5898738 into OpenMined:master Mar 1, 2020
@rav7kantsingh rav7kantsingh deleted the eslint-error-fix branch March 2, 2020 07:20
@rav7kantsingh rav7kantsingh changed the title Eslint error fixed Eslint error fix Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants