Skip to content

Forcing all websocket connections to secure if not debug mode.#107

Merged
cereallarceny merged 3 commits intoOpenMined:masterfrom
rav7kantsingh:secure-connection
Mar 13, 2020
Merged

Forcing all websocket connections to secure if not debug mode.#107
cereallarceny merged 3 commits intoOpenMined:masterfrom
rav7kantsingh:secure-connection

Conversation

@rav7kantsingh
Copy link
Member

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #107 into master will decrease coverage by 0.15%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage    71.1%   70.94%   -0.16%     
==========================================
  Files          21       21              
  Lines         713      716       +3     
  Branches       93       94       +1     
==========================================
+ Hits          507      508       +1     
- Misses        183      184       +1     
- Partials       23       24       +1
Impacted Files Coverage Δ
src/syft.js 15.09% <33.33%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd40a00...c1dde8f. Read the comment docs.

@cereallarceny
Copy link
Member

@IamRavikantSingh I think you took this PR too literally. verbose is the correct setting. I didn't want us to change the name to debug. The main issue here isn't between verbose and debug, the issue is forcing ws connections to convert to wss when not running the library locally.

@cereallarceny cereallarceny self-requested a review March 9, 2020 11:47
Copy link
Member

@cereallarceny cereallarceny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

@cereallarceny
Copy link
Member

@vvmnnnkv, can I get your thoughts?

@cereallarceny cereallarceny requested a review from vvmnnnkv March 9, 2020 13:31
@cereallarceny
Copy link
Member

@IamRavikantSingh Can you update your PR to work with the new worker API that was finished by @vvmnnnkv this morning?

@rav7kantsingh
Copy link
Member Author

rav7kantsingh commented Mar 12, 2020

What am I supposed to do to pass codecov checks? @vvmnnnkv @cereallarceny

@cereallarceny
Copy link
Member

@IamRavikantSingh don't worry about codecov. Just make sure that your code works with the new worker API - it's very different than the previous version of syft.js.

@cereallarceny cereallarceny merged commit 0d68026 into OpenMined:master Mar 13, 2020
@rav7kantsingh rav7kantsingh deleted the secure-connection branch March 13, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants