Secure web-socket connection for GridAPIClient#111
Merged
cereallarceny merged 2 commits intoOpenMined:masterfrom Mar 19, 2020
Merged
Secure web-socket connection for GridAPIClient#111cereallarceny merged 2 commits intoOpenMined:masterfrom
cereallarceny merged 2 commits intoOpenMined:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 71.15% 71.27% +0.11%
==========================================
Files 21 21
Lines 721 724 +3
Branches 95 96 +1
==========================================
+ Hits 513 516 +3
Misses 184 184
Partials 24 24
Continue to review full report at Codecov.
|
vvmnnnkv
requested changes
Mar 19, 2020
Member
vvmnnnkv
left a comment
vvmnnnkv
left a comment
There was a problem hiding this comment.
Please also force http to https
cereallarceny
approved these changes
Mar 19, 2020
This was referenced Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77
@vvmnnnkv