Update protobuf types and Plan, temporarily rollback Threepio usage#114
Merged
cereallarceny merged 4 commits intomasterfrom Apr 15, 2020
Merged
Update protobuf types and Plan, temporarily rollback Threepio usage#114cereallarceny merged 4 commits intomasterfrom
cereallarceny merged 4 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 72.16% 71.97% -0.19%
==========================================
Files 22 24 +2
Lines 740 760 +20
Branches 93 96 +3
==========================================
+ Hits 534 547 +13
- Misses 185 191 +6
- Partials 21 22 +1
Continue to review full report at Codecov.
|
vvmnnnkv
commented
Apr 12, 2020
src/types/computation-action.js
Outdated
|
|
||
| import { Threepio, Command } from '@openmined/threepio'; | ||
| const threepio = new Threepio('torch', 'tfjs', tf); | ||
| */ |
Member
Author
There was a problem hiding this comment.
Threepio is temporarily commented out.
vvmnnnkv
commented
Apr 12, 2020
src/types/computation-action.js
Outdated
| } | ||
| const cmd = new Command(functionName, resolvedArgs, this.kwargs); | ||
| const translation = threepio.translate(cmd); | ||
| return translation.executeRoutine(); |
Member
Author
There was a problem hiding this comment.
Threepio is temporarily commented out.
cereallarceny
approved these changes
Apr 15, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: