Replace bundling crypto with specific randomfill package. Fixes #161#162
Merged
cereallarceny merged 1 commit intomasterfrom Jun 15, 2020
Merged
Replace bundling crypto with specific randomfill package. Fixes #161#162cereallarceny merged 1 commit intomasterfrom
cereallarceny merged 1 commit intomasterfrom
Conversation
cereallarceny
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason
cryptofromrollup-plugin-node-builtinsdoesn't bundle properly.The fix is to use specific package
randomfill(in speed-test.js) that we need instead of wholecrypto.Fixes #161
Affected Dependencies
n/a
How has this been tested?
Bundled syft.js and used it from mnist example, to test there's no error.
Checklist