Conversation
…versing it recursively
…trary commas remaining
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
+ Coverage 75% 87.3% +12.3%
=========================================
Files 3 12 +9
Lines 100 197 +97
Branches 16 31 +15
=========================================
+ Hits 75 172 +97
Misses 20 20
Partials 5 5
Continue to review full report at Codecov.
|
iamtrask
approved these changes
Aug 1, 2019
Member
iamtrask
left a comment
There was a problem hiding this comment.
Absolutely fantastic work! Impressively fast turnaround as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we accomplished the following:
PointerTensor,TorchTensor,TorchSize,Tuple(imported from another library),Range,Slice, andPlan.