Update localisation for objects#242
Merged
ZehMatt merged 1 commit intoOpenRCT2:masterfrom May 5, 2023
Merged
Conversation
ZehMatt
force-pushed
the
merge-localisation
branch
from
3c1f81c to
7ce41c9
Compare
tupaschoal
approved these changes
May 5, 2023
Member
tupaschoal
left a comment
tupaschoal
left a comment
There was a problem hiding this comment.
I just find the removals of en-US weird
Contributor
|
en-us has been removed if identical to en-gb. |
Contributor
Author
I did that to keep it consistent, sometimes it was present with identical translation to en-gb and sometimes it wasn't, I think due to the way we use en-gb as fallback we can omit them. I can also enforce the other way around and always have en-us there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried my best to keep the diff minimal but the inconsistency is all over the place. I wrote some scripts using NodeJS to also help improve the other repo, not sure yet how the code is best shared among the two.Diff is now quite simple