Fix third colors for valkyrie & condor trains (again)#268
Merged
Gymnasiast merged 1 commit intoOpenRCT2:masterfrom Jan 18, 2024
ZeeMaji:fix_third_colors
Merged
Fix third colors for valkyrie & condor trains (again)#268Gymnasiast merged 1 commit intoOpenRCT2:masterfrom ZeeMaji:fix_third_colors
Gymnasiast merged 1 commit intoOpenRCT2:masterfrom
ZeeMaji:fix_third_colors
Conversation
Gymnasiast
approved these changes
Jan 16, 2024
tupaschoal
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While i fixed these objects in the past, recently it was brought to my attention that the yellow colors are used for handling the third remap. So while the colors i chose were decent enough the colors still weren't the intended colors for the object. So i've changed their third colors in all of their default presets to yellow.
For the condor trains the difference is barely noticeable as only a few stray pixels on a few sprites (which are a part of the yellow highlights on the vehicles) are affected by the third remap.
For the valkyrie trains the difference is much more noticeable as it affects the hair of the valkyries.

Valkyrie sprite exported (How it was intended to look ingame before the yellow remap broke it)
Valkyrie with third remap set to yellow.

Note that the third remaps for both of these vehicles are still locked, and that this will only affect the look of new instances of these vehicles in parks as old ones will preserve their old colors.