Skip to content

Split dam tower & brick base block objects#270

Merged
Gymnasiast merged 3 commits intoOpenRCT2:masterfrom
ZeeMaji:split-dam-tower
Jan 19, 2024
Merged

Split dam tower & brick base block objects#270
Gymnasiast merged 3 commits intoOpenRCT2:masterfrom
ZeeMaji:split-dam-tower

Conversation

@ZeeMaji
Copy link
Contributor

@ZeeMaji ZeeMaji commented Jan 17, 2024

Splits these two objects into two objects each, the original objects are marked as compat objects while the new ones are not. The required metadata changes for id, scenery groups, and originalid have been made so the new objects are the ones that are used in new parks.

For the original dam tower, the support rendering broke a park so the original object has it's supports removed, while the new object retains support rendering.
For the base block, the original object would block supports entirely which was used by a few parks as deliberate support blockers. While the new object allows supports to connect to them (like the vanilla base blocks)

This object had supports added to it, however this broke some parks that deliberately used it without supports.

This fixes that by turning the original object into a compat object with support rendering disabled and a new object with support rendering enabled.
@Gymnasiast Gymnasiast self-requested a review January 19, 2024 12:44
@Gymnasiast
Copy link
Member

Gymnasiast commented Jan 19, 2024

I ran the base block images through sha1 and saw that all of them are identical. Could you change it so it only has a single image in both the old and the new object?

@ZeeMaji
Copy link
Contributor Author

ZeeMaji commented Jan 19, 2024

Done, although it will still take 4 image slots ingame due to small scenery needing 4 images and i believe the object builder will still duplicate the images in the lgx file it builds. resulting in no file size change.

@Gymnasiast Gymnasiast merged commit ce8dccd into OpenRCT2:master Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants