Add all RCT1 walls#275
Merged
Gymnasiast merged 1 commit intoOpenRCT2:masterfrom Jan 28, 2024
ZeeMaji:rct1-walls
Merged
Conversation
Adds all of the RCT1 walls with different heights/colors as compat objects. For the RCT1AA glass wall i've taken the liberty of making the frame remappable for consistency with the RCT2 glass walls. Note for maintainers: There's some hard coded color converters in S4Importer.cpp within ConvertWall, these will need to be changed to import the brown wooden fence gate properly and to remove the wooden fence color remapping that will be made redundant by these walls.
Member
|
Could you provide a screenshot of their differences? There are some walls in this PR I didn’t hear about before. |
Contributor
Author
Gymnasiast
approved these changes
Jan 25, 2024
Member
Can you clarify this? Seems the brown wooden fence gate has something specific going on? |
Contributor
Author
|
Within ConvertWall in S4Importer, there's a switch case that remaps colors of walls during S4 import void ConvertWall(const int32_t& type, colour_t* colourA, colour_t* colourB)The brown wooden fence gate (RCT1_WALL_TYPE_WOODEN_PANEL_FENCE_WITH_GATE) has it's RCT1 primary color set to it's OpenRCT2 secondary color during importing as the RCT2 wooden fence gate uses the secondary color for the gate, while RCT1 uses the primary color for it. |
tupaschoal
approved these changes
Jan 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds all of the RCT1 walls with different heights/colors as compat objects. For the RCT1AA glass wall i've taken the liberty of making the frame remappable for consistency with the RCT2 glass walls.
Currently the sceneryGroup option only allows for one scenery group. So the themed walls will be placed only within their original scenery groups and not within the general fences scenery group.
Note for maintainers: There's some hard coded color converters in S4Importer.cpp within ConvertWall, these will need to be changed to import the brown wooden fence gate properly and to remove the wooden fence color remapping that will be made redundant by these walls.