fix: CALL to RET link does not detect self modifying code in some cases.#1966
Merged
maximilien-noal merged 1 commit intomasterfrom Mar 13, 2026
Conversation
kevinferrare
force-pushed
the
bugfix/call_to_ret_link_does_not_detect_self_modifying_code
branch
4 times, most recently
from
074219c to
1bfc62a
Compare
kevinferrare
force-pushed
the
bugfix/call_to_ret_link_does_not_detect_self_modifying_code
branch
from
1bfc62a to
370cb5c
Compare
maximilien-noal
approved these changes
Mar 13, 2026
kevinferrare
deleted the
bugfix/call_to_ret_link_does_not_detect_self_modifying_code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Call to Ret link in cfgcpu is not excecuted. Self modifying code detection was not working properly in this case and this was making civilization1 crash.
Tested with dune (no regression)