Skip to content

Moved cli to this repo and refactored #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshmarsh merged 3 commits into from
Oct 7, 2019
Merged

Moved cli to this repo and refactored #1

joshmarsh merged 3 commits into from
Oct 7, 2019

Conversation

@joshmarsh
Copy link
Contributor

@joshmarsh joshmarsh commented Oct 4, 2019 •
edited
Loading

  • Changed cli skeleton based on team input
  • Auto generating command reference (Check out the README)

eschwartz
eschwartz reviewed Oct 4, 2019
View reviewed changes
LICENSE Outdated
@@ -0,0 +1,202 @@

Copy link
Contributor

@eschwartz eschwartz Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same license we're using for the main repo?

Copy link
Contributor

@marinatedpork marinatedpork Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to bring over the same license as well as the other boiler plate files:

  • CODE_OF_CONDUCT.md
  • CONTRIBUTING.md
  • INDIVIDUAL_CONTRIBUTOR_LICENSE.md

Copy link
Contributor Author

@joshmarsh joshmarsh Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, this was autogenerated by the cobra CLI tool.

@eschwartz
Copy link
Contributor

eschwartz commented Oct 4, 2019

Very cool, I love the generated docs.

One thing -- I think dce accounts login should actually be dce leases login.
You're logging in as a lease holder.
This will stay in sync with the proposed GET /lease/:id/auth endpoint (cc @kddejong ).

@joshmarsh joshmarsh merged commit db31137 into master Oct 7, 2019
@joshmarsh joshmarsh deleted the feature/CliSkeleton branch October 7, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kddejong kddejong Awaiting requested review from kddejong

@AmudaPalani AmudaPalani Awaiting requested review from AmudaPalani

@marinatedpork marinatedpork Awaiting requested review from marinatedpork

@nathanagood nathanagood Awaiting requested review from nathanagood

1 more reviewer

@eschwartz eschwartz eschwartz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshmarsh @eschwartz @marinatedpork