Skip to content

#30: Removed incorrect docs #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshmarsh merged 1 commit into from
Nov 15, 2019
Merged

#30: Removed incorrect docs #31

joshmarsh merged 1 commit into from
Nov 15, 2019

Conversation

@joshmarsh
Copy link
Contributor

@joshmarsh joshmarsh commented Nov 15, 2019 •
edited
Loading

See #30

Fixed documentation on dce leases end to remove id parameter. The backend currently doesn't support this.

Created an issue to introduce support for this.

@joshmarsh joshmarsh mentioned this pull request Nov 15, 2019
Closed
@joshmarsh joshmarsh changed the title Removed incorrect docs #30: Removed incorrect docs Nov 15, 2019
@joshmarsh joshmarsh changed the title #30: Removed incorrect docs #30 Nov 15, 2019
@joshmarsh joshmarsh changed the title #30 #30: Removed incorrect docs Nov 15, 2019
@nathanagood
Copy link
Contributor

nathanagood commented Nov 15, 2019

👍

@nathanagood nathanagood self-requested a review November 15, 2019 21:20
nathanagood
nathanagood approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@nathanagood nathanagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshmarsh joshmarsh merged commit 868e8f6 into master Nov 15, 2019
@joshmarsh joshmarsh deleted the bug/lease-end-docs-id-param branch November 15, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanagood nathanagood nathanagood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshmarsh @nathanagood