Pipeline triggers and releases #5
Conversation
|
/azp list |
|
CI/CD Pipelines for this repository: |
joshmarsh
requested review from
AmudaPalani,
eschwartz,
kddejong,
marinatedpork and
nathanagood
azure-pipelines.yml
Outdated
| tagSource: 'auto' | ||
| gitHubConnection: Github | ||
| repositoryName: Optum/dce-cli | ||
| isDraft: true |
There was a problem hiding this comment.
@joshmarsh -- go ahead and disable the draft behavior, so we can test this out.
No one is using this tool yet, so feel free to create/destroy tags and releases as needed to test it out. Let's just make sure it's all cleaned up when we merge the PR
azure-pipelines.yml
Outdated
| - script: | | ||
| set -x | ||
| apt-get update | ||
| apt-get install zip -y |
There was a problem hiding this comment.
ubuntu doesn't have zip installed?
There was a problem hiding this comment.
Whoops, leftover from when I was debugging dependency issues in a container.
internal/util/aws_test.go
Outdated
|
|
||
| func TestAWSUtil(t *testing.T) { | ||
|
|
||
| t.Run("UploadDirectoryToS3 should upload an entire directory to S3", func(t *testing.T) { |
There was a problem hiding this comment.
Can we get rid of this test file? Looks like it doesn't really do anything
There was a problem hiding this comment.
I'd prefer to have at least one test file in this PR, as it's part of validating that the module can be built and tested. I can rename it to be generic if you'd like, though I'm just going to fill it in with actual tests for the AWSUtil in my next PR.
|
@joshmarsh -- this looks good. I'd just like to see this working end-to-end before we merge (ie, create a tagged release in Github) |
https://github.com/Optum/dce-cli/releases/tag/v0.0.0 |
|
|
Added an azure devops pipeline that runs tests and creates github draft releases when you push a git tag.