-
Notifications
You must be signed in to change notification settings - Fork 20
Adding tests, logging, and remaining commands #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| LevelLogger | ||
| } | ||
|
|
||
| func (l *LogObservation) Endf(format string, args ...interface{}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idomatic way of exiting with status 1 in go seems to be log.Fatal(). Added log.End() to exit 0 in cases where we need to end gracefully (e.g. user responds "no" to a confirmation prompt).
| func New(config *configs.Root, awsCreds *credentials.Credentials) *UtilContainer { | ||
| func New(config *configs.Root, observation *observ.ObservationContainer) *UtilContainer { | ||
|
|
||
| log = observation.Logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows us to use idiomatic syntax like log.Info() while still using the injected logger, as opposed to s.Observation.Info().
eschwartz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👾
|
/azp help |
Supported commands
See additional documentation. |
Summary
This PR essentially "matures" the CLI from POC status to something that you can use.
Related PRs
Optum/dce#106 corrects syntax that prevents go-swagger from generating client response models.
Code Review Tips
export DCE_LOG_LEVEL=DEBUGfor debug logs.Work contained in this PR
dce accounts list,dce accounts describe,dce leases list,dce leases describe,dce leases login, anddce usagedce system deploy