Feature/linting #75
Merged
Feature/linting #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-code-security-scanner
eschwartz
reviewed
Feb 20, 2020
| log.Println("Failed opening file", path, err) | ||
| continue | ||
| } | ||
| defer file.Close() |
Contributor
There was a problem hiding this comment.
the linting on these deferred file close calls is kind of annoying. I think in the dce repo I just did //nolint comments on them.
I might reconsider whether a failed file close is really a fatal error (line 64). I guess I'm not sure under what conditions that could happen (like if the file disappears?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enabled gofmtout and golangci-lint. Formatted code and fixed linting issues.
Merge #74 first.
Types of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesRelevant Links
Further comments