Skip to content

Conversation

@joshmarsh
Copy link
Contributor

@joshmarsh joshmarsh commented Mar 6, 2020

Proposed changes

Removes the "Lease created." output when creating a lease, so that only JSON is printed.

Lease created.
{
"accountId": "xxxx07951447",
"budgetAmount": 100,
"budgetCurrency": "USD",
"budgetNotificationEmails": [
"[email protected]"
],
"createdOn": 1583509573,
"expiresOn": 1584114371,
"id": "xxxxa77c-ac73-4f71-9a04-092b4ceeb40a",
"lastModifiedOn": 1583509573,
"leaseStatus": "Active",
"leaseStatusModifiedOn": 1583509573,
"leaseStatusReason": "Active",
"principalId": "josh1"
}

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

Copy link
Contributor

@nathanagood nathanagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Well done!

@joshmarsh joshmarsh requested a review from eschwartz March 6, 2020 16:13
@joshmarsh joshmarsh merged commit f84e1b7 into Optum:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants