Open
Conversation
- Add show_log parameter to is_in_path() to fix method signature mismatch - Disable WinRM SSL peer verification for VMware and VMware ESXi Vagrantfiles - Add VMware troubleshooting documentation for port conflicts and network setup
…templates box[:forwarded_port] do |fp| is not valid Ruby iteration — the block is silently ignored. Changed to box[:forwarded_port].each do |fp| so port forwarding (e.g. provisioning VM SSH 22->2210) actually gets configured. Affects vmware, vmware_esxi, and virtualbox providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
WindowsCommand.is_in_path()signature mismatchBase class accepts
show_logparam, but the Windows override didn't. Crashes on Windows whenon_ludus()callsself.is_in_path('ludus', False).WinRM SSL verification failure (VMware)
Windows VMs use self-signed certs. Added
config.winrm.ssl_peer_verification = falsetovmwareandvmware_esxiVagrantfiles.Broken
forwarded_portiteration (all providers)Port forwarding (e.g. provisioning VM SSH
22 -> 2210) was never configured. Fixed invmware,vmware_esxi, andvirtualboxVagrantfiles.VMware troubleshooting docs
Added section to
troobleshoot.mdfor port conflicts and VMnet adapter setup on Windows.TL;DR: it works for me, unsure if this is generic Windows vmware issues or just me. Had the same issue across 2 different builds on Windows vmware.