Skip to content

fix(lib): remove @ in import for Storybook 9+#11

Merged
vprothais merged 2 commits into
Orange-OpenSource:mainfrom
louismaximepiton:main
Jun 17, 2025
Merged

fix(lib): remove @ in import for Storybook 9+#11
vprothais merged 2 commits into
Orange-OpenSource:mainfrom
louismaximepiton:main

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

Description

Remove an @ in the import that causes:

X [ERROR] Could not resolve "@storybook/theming/create"

    node_modules/ods-storybook-theme/OrangeTheme.js:12:23:
      12 │ import { create } from '@storybook/theming/create';~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@storybook/theming/create" as external to exclude it from the bundle, which
  will remove this error and leave the unresolved path in the bundle.

Error: Build failed with 1 error:
node_modules/ods-storybook-theme/OrangeTheme.js:12:23: ERROR: Could not resolve "@storybook/theming/create"
    at failureErrorWithLog (.\node_modules\esbuild\lib\main.js:1463:15)
    at .\node_modules\esbuild\lib\main.js:924:25
    at runOnEndCallbacks (.\node_modules\esbuild\lib\main.js:1303:45)
    at buildResponseToResult (.\node_modules\esbuild\lib\main.js:922:7)
    at .\node_modules\esbuild\lib\main.js:949:16
    at responseCallbacks.<computed> (.\node_modules\esbuild\lib\main.js:601:9)
    at handleIncomingPacket (.\node_modules\esbuild\lib\main.js:656:12)
    at Socket.readFromStdout (.\node_modules\esbuild\lib\main.js:579:7)
    at Socket.emit (node:events:519:28)
    at addChunk (node:internal/streams/readable:559:12)

After the PR is merged

Maybe release a new version of the package compatible with Storybook 9+.

@vprothais
Copy link
Copy Markdown
Collaborator

I think we will have to make a v2 since it is not compatible with previous versions anymore. And we should update the compatibility table on the readme file

@vprothais vprothais merged commit e509cba into Orange-OpenSource:main Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants