refactor: hoist schema free

[Oudwins]

Summary by CodeRabbit

• Refactor

  • Enhanced internal handling of schema contexts during data parsing and validation to improve clarity and ensure consistent processing across various data types.

• Chore

  • Updated resource cleanup procedures to maintain reliable memory management without altering public behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request refactors context management across several schema files. In methods such as Parse and Validate, the direct use of ctx.NewSchemaCtx(...) was replaced with the creation of an intermediate variable (e.g., sctx or subCtx). This variable is then passed to processing and validation functions and freed using a defer statement. Additionally, the changes ensure the destination pointer is correctly passed in pointers processing and adjust the context parameters in slice validations. In one file, the automatic cleanup (defer ctx.Free()) was removed. Public API declarations remain unchanged.

Changes

Files	Change Summary
boolean.go, numbers.go, string.go, time.go	Updated context handling in Parse/Validate: create an intermediate variable (sctx) from ctx.NewSchemaCtx and free it with defer instead of inline.
pointers.go	Refactored Parse and process: now create an sctx/subCtx, passing a destination pointer in NewSchemaCtx and ensuring proper deferred cleanup.
slices.go	Adjusted context creation in Parse, Validate, and validate: use NewSchemaCtx with additional parameters and leverage subCtx for item processing.
struct.go	Modified Parse, process, and validate methods to use a subCtx for context management by directly updating context properties with deferred cleanup.
zogSchema.go	Removed defer ctx.Free() calls in primitiveProcessor and primitiveValidator, altering automatic resource cleanup in these functions.

Sequence Diagram(s)

sequenceDiagram
    participant M as Schema Method (Parse/Validate)
    participant C as NewSchemaCtx
    participant P as Process/Validate Function
    M->>C: Create new schema context (sctx)
    C-->>M: Return sctx
    M->>P: Call processing/validation with sctx
    P-->>M: Return result
    M->>M: Defer sctx.Free() for cleanup

Loading

Possibly related PRs

• perf: slice pathbuilder #106: Introduced similar context handling modifications in the Parse and Validate methods, focusing on intermediate variable creation and deferred cleanup.
• perf: implemented syncpool for internal structures #91: Directly refines context management in boolean.go using an intermediate variable and defer for resource handling.
• refactor: entire logic around creating, appending and dealing with errors refactored into common context's plus many small fixes #81: Addresses context handling across various schema structs, aligning with the refactoring approach applied in this PR.

Poem

I'm a coding bunny, hopping through the code,
Creating context variables on each busy road.
With sctx in hand and defer so neat,
My schema validations now skip a beat.
Cheers to clean context and a joyful, hoppy mode!
🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea0e0e and c75f4fd.

📒 Files selected for processing (8)

• boolean.go (2 hunks)
• numbers.go (2 hunks)
• pointers.go (2 hunks)
• slices.go (4 hunks)
• string.go (2 hunks)
• struct.go (6 hunks)
• time.go (2 hunks)
• zogSchema.go (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.