Skip to content

feat(i18n): add Japanese message for IP validator (IPv4)#195

Merged
Oudwins merged 1 commit intoOudwins:masterfrom
sawada-naoya:feat/i18n-ja-ipv4
Nov 3, 2025
Merged

feat(i18n): add Japanese message for IP validator (IPv4)#195
Oudwins merged 1 commit intoOudwins:masterfrom
sawada-naoya:feat/i18n-ja-ipv4

Conversation

@sawada-naoya
Copy link
Contributor

@sawada-naoya sawada-naoya commented Nov 3, 2025

Follow-up to #194

  • Adds JA translation for the new IP validator message (mirrors EN key: IssueCodeIP with {{ip}} param)

Summary by CodeRabbit

  • Chores
    • Added Japanese language support for IP validation messages.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Walkthrough

Added a Japanese localization entry for IP address validation to the TypeString message map. The change introduces a single translation mapping for the zconst.IssueCodeIP validation code with the corresponding Japanese message for invalid IP addresses.

Changes

Cohort / File(s) Summary
Japanese i18n Update
i18n/ja/ja.go
Added TypeString localization entry for zconst.IssueCodeIP with Japanese translation "有効な {{ip}} アドレスである必要があります"

Possibly related issues

Possibly related PRs

Suggested reviewers

  • Oudwins

Poem

🐰 A message in Japanese, clear and bright,
For IP addresses, we validate right,
With {{ip}} placeholders in place,
The translator hopped through this space! 🌟

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "feat(i18n): add Japanese message for IP validator (IPv4)" accurately describes the main change in the changeset. The actual modification adds a new localization entry to the i18n/ja/ja.go file for Japanese IP validation messages (the IssueCodeIP key with the message "有効な {{ip}} アドレスである必要があります"). The title is specific, clear, and directly corresponds to the changeset's primary objective, which is adding Japanese translations for IP validator messages as a follow-up to the IPv4 validator implementation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb3162e and 0490c8e.

📒 Files selected for processing (1)
  • i18n/ja/ja.go (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
i18n/ja/ja.go (1)
zconst/consts.go (1)
  • IssueCodeIP (137-137)
🔇 Additional comments (1)
i18n/ja/ja.go (1)

31-31: LGTM! Translation is accurate and fully consistent with other language versions.

The Japanese translation for IP address validation is correct and matches the English and Spanish versions exactly in meaning. All language files use the same {{ip}} parameter placeholder consistently, which allows proper runtime interpolation with IPv4 or IPv6 values. The translation is grammatically correct Japanese and follows the established validation message pattern.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Oudwins Oudwins merged commit 0d3278f into Oudwins:master Nov 3, 2025
5 checks passed
@Oudwins
Copy link
Owner

Oudwins commented Nov 3, 2025

Thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants