Added summary 232 #263
Closed
Added summary 232 #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for otc-catchup pending review.Visit the deploys page to approve it
|
SirusCodes
requested changes
May 1, 2025
package.json
Outdated
| "@netlify/edge-functions": "^2.5.1", | ||
| "dotenv": "^16.3.1" | ||
| "dotenv": "^16.3.1", | ||
| "express": "^5.1.0" |
| . Abhinav Singh | ||
| . Ayush Shukla | ||
| . Pawan K | ||
| . Uma Iyer |
PranavDani
reviewed
May 1, 2025
Member
PranavDani
left a comment
PranavDani
left a comment
There was a problem hiding this comment.
Just use some extension to check grammar, or you could even ask copilot to give a simple grammar check and adjust sentences accordingly.
These fixes should take 5 minutes, I hope you update it.
Also you get to learn how to modify a PR.
|
|
||
| ==== Topics Discussed | ||
|
|
||
| * Dheeraj presentated and discussed I-frames are full images, while P-frames store only changes from previous frames, reducing file size by avoiding repetition and helps reduce file sizes by leveraging the similarities between consecutive video frames . |
Member
There was a problem hiding this comment.
This can be split in points:
- Dheeraj presented and discussed I-frames.
** I frames are ... whereas P-frames are ...
|
|
||
| * Dheeraj presentated and discussed I-frames are full images, while P-frames store only changes from previous frames, reducing file size by avoiding repetition and helps reduce file sizes by leveraging the similarities between consecutive video frames . | ||
| ** link:http://dranger.com/ffmpeg[ffmpeg^] - ffmeg | ||
| * Rishit shared about modern video and image encoders |
Member
There was a problem hiding this comment.
This could be a single point:
Rishit talked about ...., which is a .....
"Shared about" does not fit here. "Talked about" or just "shared" is better.
| ** link:http://dranger.com/ffmpeg[ffmpeg^] - ffmeg | ||
| * Rishit shared about modern video and image encoders | ||
| ** link:https://github.com/NVIDIA/Cosmos-Tokenizer[Cosmos-Tokenizer^] - Cosmos-Tokenizer | ||
| * Discussed about Arithmetic coding compresses data by representing an entire message as a single number between 0 and 1, using symbol probabilities. |
Member
There was a problem hiding this comment.
Again, "discussed about" might not be the best start for a sentence.
Plus who discussed?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added summary of catch up 232