Skip to content

Comments

[Oztechan/CCC#3590] Remove CalculatorFragment navigation result logic#3595

Merged
mustafaozhan merged 4 commits intodevelopfrom
3590-Remove-CalculatorFragment-navigation-result-logic
Jun 25, 2024
Merged

[Oztechan/CCC#3590] Remove CalculatorFragment navigation result logic#3595
mustafaozhan merged 4 commits intodevelopfrom
3590-Remove-CalculatorFragment-navigation-result-logic

Conversation

@mustafaozhan
Copy link
Member

Resolves #3590

@mustafaozhan mustafaozhan requested a review from a team as a code owner June 24, 2024 18:57
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-19.68% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6a46d24) 3298 1713 51.94%
Head commit (adb12b1) 5859 (+2561) 1890 (+177) 32.26% (-19.68%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3595) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.37%. Comparing base (6a46d24) to head (adb12b1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3595      +/-   ##
===========================================
+ Coverage    55.19%   55.37%   +0.19%     
===========================================
  Files          166      166              
  Lines         2970     2960      -10     
  Branches       440      439       -1     
===========================================
  Hits          1639     1639              
+ Misses        1300     1291       -9     
+ Partials        31       30       -1     

Impacted file tree graph

Files Coverage Δ
...ui/mobile/content/calculator/CalculatorFragment.kt 0.00% <ø> (ø)
...ui/mobile/content/currencies/CurrenciesFragment.kt 0.00% <0.00%> (ø)

@mustafaozhan mustafaozhan merged commit 8995aa1 into develop Jun 25, 2024
@mustafaozhan mustafaozhan deleted the 3590-Remove-CalculatorFragment-navigation-result-logic branch June 25, 2024 07:25
mustafaozhan added a commit that referenced this pull request Jun 30, 2024
mustafaozhan added a commit that referenced this pull request Jun 30, 2024
* Revert "[#3591] Remove set and get navigation results (#3596)"

This reverts commit 8ef9402.

* Revert "[#3590] Remove CalculatorFragment navigation result logic (#3595)"

This reverts commit 8995aa1.

* Revert "[#3587] Remove CurrenciesFragment navigation result logic (#3589)"

This reverts commit eee3c4b.

* Revert "[#3585] Remove SelectCurrencyFragment navigation result logic (#3586)"

This reverts commit 6a46d24.

* Revert "[#3592] Use the currentBase stored in preference at onResume (#3594)"

This reverts commit 583c415.

* [#3638] Add back navigation result logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove CalculatorFragment navigation result logic

1 participant