Skip to content

Comments

[Oztechan/CCC#3731] Get rid of CoroutinesUtil for ViewModels#3732

Merged
mustafaozhan merged 1 commit intodevelopfrom
3731-Get-rid-of-CoroutinesUtil-for-ViewModels
Aug 4, 2024
Merged

[Oztechan/CCC#3731] Get rid of CoroutinesUtil for ViewModels#3732
mustafaozhan merged 1 commit intodevelopfrom
3731-Get-rid-of-CoroutinesUtil-for-ViewModels

Conversation

@mustafaozhan
Copy link
Member

Resolves #3731

@mustafaozhan mustafaozhan requested a review from a team as a code owner July 27, 2024 15:26
@mustafaozhan mustafaozhan changed the base branch from develop to 3729-Simplfiy-WidgetViewModel July 27, 2024 15:26
@mustafaozhan mustafaozhan force-pushed the 3729-Simplfiy-WidgetViewModel branch 2 times, most recently from c06954b to 199d97f Compare August 3, 2024 18:09
Base automatically changed from 3729-Simplfiy-WidgetViewModel to develop August 3, 2024 18:17
@mustafaozhan mustafaozhan force-pushed the 3731-Get-rid-of-CoroutinesUtil-for-ViewModels branch from 14cf5db to 88fec67 Compare August 3, 2024 18:19
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (413fbe4) 3235 1716 53.04%
Head commit (88fec67) 3228 (-7) 1710 (-6) 52.97% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3732) 22 22 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (413fbe4) to head (88fec67).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3732      +/-   ##
===========================================
- Coverage    56.57%   56.51%   -0.06%     
===========================================
  Files          166      166              
  Lines         2915     2911       -4     
  Branches       436      436              
===========================================
- Hits          1649     1645       -4     
  Misses        1240     1240              
  Partials        26       26              

Impacted file tree graph

Files Coverage Δ
...an/ccc/android/viewmodel/widget/WidgetViewModel.kt 96.23% <ø> (-0.20%) ⬇️
...client/viewmodel/calculator/CalculatorViewModel.kt 99.30% <100.00%> (ø)
...client/viewmodel/currencies/CurrenciesViewModel.kt 97.40% <100.00%> (-0.03%) ⬇️
...ccc/client/viewmodel/watchers/WatchersViewModel.kt 97.92% <100.00%> (ø)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2024

@mustafaozhan mustafaozhan merged commit 9a3bc56 into develop Aug 4, 2024
@mustafaozhan mustafaozhan deleted the 3731-Get-rid-of-CoroutinesUtil-for-ViewModels branch August 4, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of CoroutinesUtil for ViewModels

1 participant