Skip to content

Comments

[Oztechan/CCC#3878] Create onSheetDismissed Event for CalculatorViewModel#3879

Merged
mustafaozhan merged 1 commit intodevelopfrom
3878-Create-onSheetDismissed-Event-for-CalculatorViewModel
Sep 9, 2024
Merged

[Oztechan/CCC#3878] Create onSheetDismissed Event for CalculatorViewModel#3879
mustafaozhan merged 1 commit intodevelopfrom
3878-Create-onSheetDismissed-Event-for-CalculatorViewModel

Conversation

@mustafaozhan
Copy link
Member

Resolves #3878

@mustafaozhan mustafaozhan requested a review from a team as a code owner September 9, 2024 07:42
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.12% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6bde618) 3214 1718 53.45%
Head commit (4d1fc75) 3221 (+7) 1718 (+0) 53.34% (-0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3879) 7 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (6bde618) to head (4d1fc75).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...client/viewmodel/calculator/CalculatorViewModel.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3879      +/-   ##
===========================================
- Coverage    57.12%   57.00%   -0.12%     
===========================================
  Files          166      166              
  Lines         2894     2900       +6     
  Branches       432      434       +2     
===========================================
  Hits          1653     1653              
- Misses        1217     1223       +6     
  Partials        24       24              

Impacted file tree graph

Files with missing lines Coverage Δ
.../ccc/client/viewmodel/calculator/CalculatorSEED.kt 100.00% <ø> (ø)
...client/viewmodel/calculator/CalculatorViewModel.kt 95.30% <0.00%> (-4.00%) ⬇️

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

@mustafaozhan mustafaozhan merged commit 7711e6a into develop Sep 9, 2024
@mustafaozhan mustafaozhan deleted the 3878-Create-onSheetDismissed-Event-for-CalculatorViewModel branch September 9, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create onSheetDismissed Event for CalculatorViewModel

1 participant