Skip to content

Comments

[Oztechan/CCC#3891] Remove ChangeBase Event from Currencies Screen#3892

Merged
mustafaozhan merged 1 commit intodevelopfrom
3891-Remove-ChangeBase-Event-from-Currencies-Screen
Sep 11, 2024
Merged

[Oztechan/CCC#3891] Remove ChangeBase Event from Currencies Screen#3892
mustafaozhan merged 1 commit intodevelopfrom
3891-Remove-ChangeBase-Event-from-Currencies-Screen

Conversation

@mustafaozhan
Copy link
Member

Resolves #3891

@mustafaozhan mustafaozhan requested a review from a team as a code owner September 10, 2024 10:57
@codacy-production
Copy link

codacy-production bot commented Sep 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9ace415) 3223 1724 53.49%
Head commit (ee15cc5) 3220 (-3) 1722 (-2) 53.48% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3892) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.12%. Comparing base (9ace415) to head (ee15cc5).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3892      +/-   ##
===========================================
- Coverage    57.13%   57.12%   -0.01%     
===========================================
  Files          166      166              
  Lines         2902     2899       -3     
  Branches       435      434       -1     
===========================================
- Hits          1658     1656       -2     
+ Misses        1220     1218       -2     
- Partials        24       25       +1     

Impacted file tree graph

Files with missing lines Coverage Δ
...ui/mobile/content/currencies/CurrenciesFragment.kt 0.00% <ø> (ø)
.../ccc/client/viewmodel/currencies/CurrenciesSEED.kt 100.00% <ø> (ø)
...client/viewmodel/currencies/CurrenciesViewModel.kt 97.37% <ø> (-0.03%) ⬇️

@sonarqubecloud
Copy link

@mustafaozhan mustafaozhan merged commit c243d3f into develop Sep 11, 2024
@mustafaozhan mustafaozhan deleted the 3891-Remove-ChangeBase-Event-from-Currencies-Screen branch September 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ChangeBase Event from Currencies Screen

1 participant