Skip to content

Comments

[Oztechan/CCC#3895] Replace onBaseChanged in Watchers with onSourceChanged#3896

Merged
mustafaozhan merged 3 commits intodevelopfrom
3895-Replace-onBaseChanged-in-Watchers-with-onSourceChanged
Sep 12, 2024
Merged

[Oztechan/CCC#3895] Replace onBaseChanged in Watchers with onSourceChanged#3896
mustafaozhan merged 3 commits intodevelopfrom
3895-Replace-onBaseChanged-in-Watchers-with-onSourceChanged

Conversation

@mustafaozhan
Copy link
Member

Resolves #3895

@mustafaozhan mustafaozhan requested a review from a team as a code owner September 12, 2024 15:14
@codacy-production
Copy link

codacy-production bot commented Sep 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (79e4dac) 3220 1722 53.48%
Head commit (09b37f3) 3220 (+0) 1722 (+0) 53.48% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3896) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.12%. Comparing base (79e4dac) to head (09b37f3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3896   +/-   ##
========================================
  Coverage    57.12%   57.12%           
========================================
  Files          166      166           
  Lines         2899     2899           
  Branches       434      434           
========================================
  Hits          1656     1656           
  Misses        1218     1218           
  Partials        25       25           

Impacted file tree graph

Files with missing lines Coverage Δ
...android/ui/mobile/content/watchers/WatchersView.kt 0.00% <ø> (ø)
...chan/ccc/client/viewmodel/watchers/WatchersSEED.kt 100.00% <ø> (ø)
...ccc/client/viewmodel/watchers/WatchersViewModel.kt 97.92% <100.00%> (ø)

@mustafaozhan mustafaozhan merged commit 21579f0 into develop Sep 12, 2024
@mustafaozhan mustafaozhan deleted the 3895-Replace-onBaseChanged-in-Watchers-with-onSourceChanged branch September 12, 2024 15:42
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace onBaseChanged in Watchers with onSourceChanged

1 participant