fix: CPython 3.13+ resolves frame addresses using stack_chunk #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taegyunkim
force-pushed
the
taegyunkim/stackchunk-crash
branch
from
c6d8955 to
c982a7a
Compare
P403n1x87
reviewed
Feb 28, 2025
taegyunkim
commented
Mar 1, 2025
P403n1x87
reviewed
Mar 3, 2025
taegyunkim
changed the title
P403n1x87
reviewed
Mar 3, 2025
Owner
P403n1x87
left a comment
P403n1x87
left a comment
There was a problem hiding this comment.
I'm having a bit of trouble reviewing this because of the formatting change. Can we remove those and maybe do them in another PR if necessary? 🙏
P403n1x87
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#74 enabled us to read from local
stack_chunkwhen available. And some of CPython 3.13+ tests were segfaulting since then, see #85 for examples. This PR fixes them.Since CPython 3.13, objects other than code objects can exist as "executable" of an internal frame, see python/cpython#105727. This required us to iterate over frame objects checking the type, and we need to make sure those frame addresses are resolved using
stack_chunkor copied properly.