manager for sport_obj, event_grp_obj and event_obj#32
Open
Dimfred wants to merge 18 commits intoPBSA:beatricefrom
Open
manager for sport_obj, event_grp_obj and event_obj#32Dimfred wants to merge 18 commits intoPBSA:beatricefrom
Dimfred wants to merge 18 commits intoPBSA:beatricefrom
Conversation
add last_vote_time to account statistics
Dividends testcases fixes
xeroc
suggested changes
Jan 28, 2019
xeroc
reviewed
Feb 1, 2019
xeroc
reviewed
Feb 1, 2019
Contributor
|
Excellent work on the pull request ... need community/management to agree on it for merging. @Dimfred can you provide a specification so we have a PIP? |
pmconrad
reviewed
Feb 6, 2019
pmconrad
left a comment
pmconrad
left a comment
There was a problem hiding this comment.
All these changes are modifying consensus rules and need hardfork protection.
pmconrad
reviewed
Feb 6, 2019
Contributor
|
Interestingly, We have |
xeroc
force-pushed
the
feature/manager-for-sports-and-underlying
branch
from
d47948d to
7a3ed9d
Compare
xeroc
force-pushed
the
feature/manager-for-sports-and-underlying
branch
from
7a3ed9d to
ab4749d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a manager attribute for the objects above.
Every manager, higher in the object hierachy can also modify objects below (sport can mod eventgrp & event).