✨ New Generic.WhiteSpace.GotoTargetSpacing sniff#1026
Merged
Conversation
Member
Author
|
Just saw I cherrypicked an outdated commit. Fixed up now. |
What with the colon for a goto target label no longer being tokenized to be included in the label token, let's allow for people to enforce no space between the label and the colon. This commit introduces a new sniff to do just that. Includes tests. Includes documentation. Related to 185
jrfnl
force-pushed
the
phpcs-4.0/feature/new-generic-gototargetspacing-sniff
branch
from
d2e0cc0 to
a133003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What with the colon for a goto target label no longer being tokenized to be included in the label token, let's allow for people to enforce no space between the label and the colon.
This commit introduces a new sniff to do just that.
Includes tests.
Includes documentation.
Suggested changelog entry
Added:
New sniff
Generic.WhiteSpace.GotoTargetSpacingto enforce no space between the label of agototarget and the colon following it.Related issues/external references
Related to #185