Conversation
…s[i]bility` error code Follow up on #792, related to #1135 The `SpacingAfterVis[i]bility` error code was introduced in v 3.12.0 (March this year) for constructor property promotion. The `SpacingAfterSetVis[i]bility` error code was introduced in v 3.13.1 (this month) for constructor property promotion with asym visibility. Both contained the same typo. PR 1135 fixes the asym error code and will be included in PHPCS 3.13.2. This commit now fixes the non-asym error code and will be included in PHPCS 4.0.0.
jrfnl
deleted the
phpcs-4.0/feature/squiz-functiondeclarationargumentspacing-fix-errorcode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #792, related to #1135
The
SpacingAfterVis[i]bilityerror code was introduced in v 3.12.0 (March this year) for constructor property promotion. TheSpacingAfterSetVis[i]bilityerror code was introduced in v 3.13.1 (this month) for constructor property promotion with asym visibility.Both contained the same typo.
PR #1135 fixes the asym error code and will be included in PHPCS 3.13.2.
This commit now fixes the non-asym error code and will be included in PHPCS 4.0.0.
Suggested changelog entry
Changed: Squiz.Functions.FunctionDeclarationArgumentSpacing: the
SpacingAfterVisbilityerror code toSpacingAfterVisibilityTypes of changes