[Documentation] PSR12 - Boolean Operator Placement#181
Merged
jrfnl merged 1 commit intoPHPCSStandards:masterfrom Jan 6, 2024
Conversation
77 tasks
jrfnl
requested changes
Jan 5, 2024
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
Member
|
P.S.: Would you mind rebasing the PR before you continue work on it ? That should allow to get a passing build. |
Contributor
Author
|
@jrfnl Before I rebase can you just check the change I made to the standard definition? |
Member
I'm fine with it as it is now. For readability you could consider restructuring it a little like below, but that's up to you. Either way is fine by me. Aside from the "Invalid" description for the second code block, this is now good to go as far as I'm concerned. |
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
3771116 to
787fb83
Compare
jrfnl
approved these changes
Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR contains the documentation for the PSR12/ControlStructures/BooleanOperatorPlacement sniff.
Description
This PR will add the documentation for the above-mentioned sniff, according to the official standard definitions.
Suggested changelog entry
Add documentation for the PSR12 BooleanOperatorPlacement sniff
Related issues/external references
Part of #148
Types of changes
PR checklist