Skip to content

Allow setting top and bottom margins, write table margins in PPTX writer#315

Merged
Progi1984 merged 1 commit into
PHPOffice:developfrom
theviralab:develop
Feb 25, 2017
Merged

Allow setting top and bottom margins, write table margins in PPTX writer#315
Progi1984 merged 1 commit into
PHPOffice:developfrom
theviralab:develop

Conversation

@carlosafonso
Copy link
Copy Markdown
Contributor

This PR allows setting bottom and top margins, and propagates those margins (as well as left and right) when serializing table objects.

I think this would cover what is requested in #273.

@ellisgl
Copy link
Copy Markdown

ellisgl commented Feb 2, 2017

This would be nice to have!

@Progi1984 Progi1984 added this to the 0.8.0 milestone Feb 25, 2017
@Progi1984 Progi1984 self-assigned this Feb 25, 2017
@Progi1984 Progi1984 merged commit 3e0ce0a into PHPOffice:develop Feb 25, 2017
Progi1984 added a commit to Progi1984/PHPPresentation that referenced this pull request Feb 25, 2017
Progi1984 added a commit that referenced this pull request Feb 25, 2017
#315 : PowerPoint2007 Writer : Support of margins in cell in table
@Progi1984
Copy link
Copy Markdown
Member

Progi1984 commented Feb 25, 2017

Merged in develop branch

@ajmorenodelarosa
Copy link
Copy Markdown

Niceeee, awesome feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants