Remove Dependencies #256
Merged
Remove Dependencies #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishaduck
force-pushed
the
thin-deps
branch
5 times, most recently
from
e440a61 to
314f3d1
Compare
Member
Author
|
@ParkerH27, @PetalCat—Requesting review! |
PetalCat
previously approved these changes
Dec 11, 2023
lishaduck
force-pushed
the
thin-deps
branch
2 times, most recently
from
0461652 to
b82c89c
Compare
Member
Author
|
I fixed CI! This works! |
lishaduck
force-pushed
the
thin-deps
branch
2 times, most recently
from
90bf654 to
9504029
Compare
This was referenced Jan 3, 2024
Member
Author
|
@ParkerH27, can you take a look at this on before the weekend? |
ParkerH27
previously approved these changes
Feb 2, 2024
It'd be useful if it weren't so darn slow! As it is, it slows down `build_runner` from ~30s -> ~90s. I'm removing it, we can re-evaluate it later.
Might be slightly faster, maybe? Also, more secure! (Definitely)
Remove more unused code and dependencies!
Fixes #263 Also contains this squashed commit: * fix: expect success on tap target test
They're transitives now, but at least the pubspec's shorter.
Use envied instead of dart_define.
Rather than uploading as an artifact, we now cache the files. Should fix ci.
ParkerH27
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR'll remove unnecessary dependencies, and maybe do some other related, low-hanging refactors as well.
Closes: #253
Type of Change