Fix panic in From<io::Error> implementation for frame::Error#221
Merged
Conversation
phoerious
added a commit
to chatnoir-eu/chatnoir-resiliparse
that referenced
this pull request
May 8, 2026
Owner
|
Thanks for the fix! |
Owner
|
released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Fromimplementation for converting anio::Errorto aframe::Erroralways panics for custom IO errors.This is the current implementation:
This will always panic on the last
unwrap()for any kind of custom IO error that is not a wrappedframe::Error, regardless of whethere.downcast_ref::<Error>()actually succeeded.I changed the
map()call toand_then(), which is probably the originally intended behaviour.Found this bug while testing error propagation in my own LZ4 stream wrapper implementation, which uses lz4_flex as a backend.