Merged
Conversation
improve duplicate_overlapping unsafe version. The compiler generates unfavourable assembly for the simple version. Now we copy 4 bytes, instead of one in every iteration. Without that the compiler will unroll/auto-vectorize the copy with a lot of branches. This is not what we want, as large overlapping copies are not that common.
PSeitz
added a commit
that referenced
this pull request
Apr 30, 2023
fixes checked decode checks revert #69 as this leads to out of bounds writes
Merged
PSeitz
added a commit
that referenced
this pull request
Apr 30, 2023
fixes checked decode checks revert #69 as this leads to out of bounds writes
PSeitz
added a commit
that referenced
this pull request
May 27, 2023
This is another attempt to replace the aggressive compiler after the failed attempt #69 (wrote out of bounds in some cases) The unrolling is avoided by manually unrolling less aggressive. Decompression performance is slightly improved by ca 4%, except the smallest test case.
PSeitz
added a commit
that referenced
this pull request
May 27, 2023
This is another attempt to replace the aggressive compiler after the failed attempt #69 (wrote out of bounds in some cases) The unrolling is avoided by manually unrolling less aggressive. Decompression performance is slightly improved by ca 4%, except the smallest test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve duplicate_overlapping unsafe version. The compiler generates unfavourable assembly for the simple version.
Now we copy 4 bytes, instead of one in every iteration.
Without that the compiler will unroll/auto-vectorize the copy with a lot of branches.
This is not what we want, as large overlapping copies are not that common.