Skip to content

simplify extend_from_within_overlapping #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PSeitz merged 1 commit into from
Feb 1, 2023
Merged

simplify extend_from_within_overlapping #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/sink.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,12 @@ impl<'a> SliceSink<'a> {

#[inline]
#[cfg(any(feature = "safe-decode"))]
pub(crate) fn extend_from_within_overlapping(&mut self, start: usize, len: usize) {
// Sink safety invariant guarantees that the first `pos` items are always initialized.
assert!(start <= self.pos);
pub(crate) fn extend_from_within_overlapping(&mut self, start: usize, num_bytes: usize) {
let offset = self.pos - start;
let out = &mut self.output[start..self.pos + len];
out[offset] = 0; // ensures that a copy w/ start == pos becomes a zero fill
for i in offset..out.len() {
out[i] = out[i - offset];
for i in start + offset..start + offset + num_bytes {
self.output[i] = self.output[i - offset];
}
self.pos += len;
self.pos += num_bytes;
}
}

Expand Down