Conversation
Owner
PSeitz
commented
Feb 2, 2023
those assertions are only used in safe code and therefore unnecessary
Improve safe decompression speed by 8-18% Reduce multiple slice fetches. every slice access, also nested ones ,carries some overhead. In the hot loop a fixed &[u8;16] is fetched to operate on. This is purely done to pass that info to the compiler. Remove error handling that only carries overhead. As we are in safe mode we can rely on bounds checks if custom error handling only adds overhead. In normal operation no error should occur. The strategy to identify improvements was by counting the lines of assembly. A rough heuristic, but seems effective. cargo asm --release --example decompress_block decompress_block::main | wc -l
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.