Skip to content

Comments

[CI] Refactor check-bypass logic in run_tests_with_coverage#4655

Merged
EmmonsCurse merged 3 commits intoPaddlePaddle:developfrom
EmmonsCurse:fix_skip_ci
Nov 7, 2025
Merged

[CI] Refactor check-bypass logic in run_tests_with_coverage#4655
EmmonsCurse merged 3 commits intoPaddlePaddle:developfrom
EmmonsCurse:fix_skip_ci

Conversation

@EmmonsCurse
Copy link
Collaborator

@EmmonsCurse EmmonsCurse commented Oct 29, 2025

Motivation

Improve CI efficiency by updating the check-bypass logic to handle new commits.

Adjusted the logic for the skip-ci: coverage mechanism to prevent cases where coverage-exempted PRs skip all test verification after code updates.
Now, the skip flag only bypasses the coverage check, not the unit test execution.

For PRs with coverage exemption requests, a reminder will be shown to encourage maintainers to review and merge them promptly.
If the code is updated afterward, tests will still be executed to ensure correctness.

Modifications

Updated check-bypass workflow to use commit SHA for skip determination.

Usage or Command

No user-facing changes.

Accuracy Tests

Functionality unaffected, no tests needed.

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Oct 29, 2025

Thanks for your contribution!

@EmmonsCurse EmmonsCurse force-pushed the fix_skip_ci branch 2 times, most recently from b74b5d8 to b9889ab Compare October 29, 2025 09:03
@EmmonsCurse EmmonsCurse changed the title [CI] Change check-bypass workflow using commit SHA [CI] Refactor check-bypass logic in run_tests_with_coverage Oct 29, 2025
XieYunshen
XieYunshen previously approved these changes Nov 4, 2025
Copy link
Collaborator

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmonsCurse EmmonsCurse merged commit d0f9535 into PaddlePaddle:develop Nov 7, 2025
14 of 15 checks passed
@EmmonsCurse EmmonsCurse deleted the fix_skip_ci branch November 7, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants