[BugFix] fix work metrics not returned by metrics api#4912
Merged
Jiang-Jia-Jun merged 5 commits intoPaddlePaddle:developfrom Nov 25, 2025
Merged
Conversation
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4912 +/- ##
==========================================
Coverage ? 59.73%
==========================================
Files ? 317
Lines ? 38683
Branches ? 5815
==========================================
Hits ? 23106
Misses ? 13750
Partials ? 1827
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jiang-Jia-Jun
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
当前的 metrics 接口,只返回了
main_process_metrics的信息,而没有返回work_process_metrics中包含的指标。排查到是因为PROMETHEUS_MULTIPROC_DIR环境变量的设置晚于work_process_metrics的实例化导致的,work_process_metrics中的指标没有以多进程的模式被初始化,从而multiprocess.MultiProcessCollector没有到收集相关信息。Modifications
将环境变量
PROMETHEUS_MULTIPROC_DIR的初始化提前到fastdeploy/__init__.py文件中,这样通过python -m fastdeploy.entrypoints.openai.api_server启动服务时立即初始化该环境变量。Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.