Skip to content

Comments

[CI] Add RD in env CI.#5345

Merged
EmmonsCurse merged 3 commits intoPaddlePaddle:developfrom
Wanglongzhi2001:env_ci_new
Dec 3, 2025
Merged

[CI] Add RD in env CI.#5345
EmmonsCurse merged 3 commits intoPaddlePaddle:developfrom
Wanglongzhi2001:env_ci_new

Conversation

@Wanglongzhi2001
Copy link
Collaborator

Motivation

Modify env ci(add RD).

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

Add RD in env CI.

Usage or Command

None.

Accuracy Tests

None.

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

Copilot AI review requested due to automatic review settings December 3, 2025 02:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the CI approval requirements by adding a new FastDeploy RD (Jiang-Jia-Jun) to the list of reviewers required for changes to fastdeploy/envs.py. However, the PR also includes an unexpected addition of a test environment variable to the production code.

Key Changes:

  • Added Jiang-Jia-Jun as a required approver for fastdeploy/envs.py modifications
  • Added a test environment variable FD_PREFILL_WAIT_DECODE_RESOURCE_SECONDS_test to the production environment configuration

Note on PR Description: The PR description only mentions adding RD to the CI approval list, but does not explain why the test environment variable is being added to fastdeploy/envs.py. Please update the description to explain the purpose of this additional change, or if this is unintended, consider removing it from this PR.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

File Description
scripts/check_approval.sh Updates the approval requirement list to include Jiang-Jia-Jun as an additional required reviewer for environment file changes
fastdeploy/envs.py Adds a test environment variable that appears inconsistent with the PR's stated purpose

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@0eb799a). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5345   +/-   ##
==========================================
  Coverage           ?   59.34%           
==========================================
  Files              ?      324           
  Lines              ?    40058           
  Branches           ?     6052           
==========================================
  Hits               ?    23771           
  Misses             ?    14401           
  Partials           ?     1886           
Flag Coverage Δ
GPU 59.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmmonsCurse EmmonsCurse merged commit f6544c0 into PaddlePaddle:develop Dec 3, 2025
15 of 17 checks passed
@paddle-bot
Copy link

paddle-bot bot commented Dec 3, 2025

Thanks for your contribution!

@Wanglongzhi2001 Wanglongzhi2001 deleted the env_ci_new branch January 29, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants