[CI] Add RD in env CI.#5345
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the CI approval requirements by adding a new FastDeploy RD (Jiang-Jia-Jun) to the list of reviewers required for changes to fastdeploy/envs.py. However, the PR also includes an unexpected addition of a test environment variable to the production code.
Key Changes:
- Added Jiang-Jia-Jun as a required approver for
fastdeploy/envs.pymodifications - Added a test environment variable
FD_PREFILL_WAIT_DECODE_RESOURCE_SECONDS_testto the production environment configuration
Note on PR Description: The PR description only mentions adding RD to the CI approval list, but does not explain why the test environment variable is being added to fastdeploy/envs.py. Please update the description to explain the purpose of this additional change, or if this is unintended, consider removing it from this PR.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/check_approval.sh | Updates the approval requirement list to include Jiang-Jia-Jun as an additional required reviewer for environment file changes |
| fastdeploy/envs.py | Adds a test environment variable that appears inconsistent with the PR's stated purpose |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5345 +/- ##
==========================================
Coverage ? 59.34%
==========================================
Files ? 324
Lines ? 40058
Branches ? 6052
==========================================
Hits ? 23771
Misses ? 14401
Partials ? 1886
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your contribution! |
Motivation
Modify env ci(add RD).
Modifications
Add RD in env CI.
Usage or Command
None.
Accuracy Tests
None.
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.