[Cherry-Pick][BugFix] Fix misleading logging in worker_process for request counting (#5939)#5953
Merged
Jiang-Jia-Jun merged 3 commits intorelease/2.4from Jan 9, 2026
Merged
Conversation
|
Thanks for your contribution! |
|
|
…unting (PR #5939) Co-authored-by: Jiang-Jia-Jun <163579578+Jiang-Jia-Jun@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Cherry pick changes from PR #5939 into release/2.4 branch
[Cherry-Pick][BugFix] Fix misleading logging in worker_process for request counting (#5939)
Jan 8, 2026
Jiang-Jia-Jun
approved these changes
Jan 8, 2026
Collaborator
|
@copilot Your PR code style check failed. Then, run pre-commit to check codestyle issues in your PR: |
Jiang-Jia-Jun
approved these changes
Jan 8, 2026
Co-authored-by: Jiang-Jia-Jun <163579578+Jiang-Jia-Jun@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick PR #5939 from develop to release/2.4 branch. The original logging misrepresented metrics:
num_running_requestsprinted the batch slot index (not request count), andnum_insert_requestsincluded DECODE requests (not just new inserts).Modifications
Variable renaming and cleanup:
num_running_requests→max_occupied_batch_index(3 locations: initialization, assignment, function calls)req_idsvariable initializationAccurate request counting:
RequestTypeto distinguish PREFILL vs DECODE requestsnum_prefill_requests: count of PREFILL requests in current batchnum_scheduled_requests: total requests scheduled in batchreq_ids→scheduled_request_idsfor clarityUpdated log output:
Before:
After:
Usage or Command
No usage changes. Logging output now accurately reflects request metrics for debugging and monitoring.
Accuracy Tests
N/A - logging change only, no model output affected.
Checklist
pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.