Add Feishin icon

[Adra642]

Add Feishin icon and symlinks, close #3818

[achadwick]

Hi @Adra642 - it's looking good!

This is a nicely optimized PR, close to upstream but better for our look. The shapes are mostly nicely aligned to pixel boundaries too. There are just a few things to look at if you have time...

1. Looks like some matrix transforms have crept in on the groups you're using. You can see them in the XML view (Ctrl+Shift+X), or in the raw diff. Please can you "apply" them?

   • Click the group, ungroup its members (Ctrl+Shift+G)
   • Then either re-Group them (Ctrl+G), or Union them (Ctrl and +) if they are just paths
   • Either way the matrix math is applied to each of the points by the ungrouping.

2. Clarity. I think the shadow under the logo may make it appear less sharp, especially at the intermediate and small sizes. It could also be a shade darker for extra contrast.

   • Consider removing the shadow at sizes under 64px or 48px. It's because it's a dark shape on a light background.
   • Note that 64x64 is used for HUGE renderings that should look pretty, so maybe keep the shadow on that? ;)
   • It's reasonable to go as low as #333333 or whatever DESIGN.md says if the "black" is on a light background.

3. Fine-tuning. Could the really small sizes (16, 22, 24) be made symmetrical in the vertical axis by scaling the entire design 1 pixel smaller? That way the dot can be made to hit a pixel centre, and you might get to see the circular empty space around it more clearly as well

   • You can probably get away with it a little more at 32px
   • The 48/64 sizes look fine for this

Let me know if you'd like me to handle it, and do tell me if that makes no sense :D

[Adra642]

I think I've solved the issue with the shadows and the transforms. I also tried to improve the small sizes scale, but I'm not completely sure if it's perfect yet. Feel free to make any changes if needed.

[achadwick]

Hi @Adra642 -

I need to do a little more work on it still, but merged! Thank you~